Add Open in Editor support for template paths #2198
Conversation
federicobond
force-pushed
the
open-in-editor
branch
from
5102676 to
543c143
Compare
|
Ah, that's a good reference. I like the idea of having a magic-ish value/constant to specify rather than asking them to write in a lambda for a setting. |
federicobond
force-pushed
the
open-in-editor
branch
2 times, most recently
from
33d4005 to
99f0190
Compare
federicobond
force-pushed
the
open-in-editor
branch
from
99f0190 to
418e706
Compare
|
@tim-schilling updated to use a constant to specify the editor URL format. Test failures appear unrelated. |
federicobond
force-pushed
the
open-in-editor
branch
from
f844db5 to
bda95cf
Compare
There was a problem hiding this comment.
This is looking good. Marking it as Request Changes to ask for the tests. I think tests that cover get_editor_url and the new get_stats() of TemplatesPanel would be great.
The other stretch thing would be to add is a reference to the new setting in the TemplatesPanel documentation.
|
I just added the requested tests and updated the docs format. I would prefer to hold off with documenting this as something that's mostly useful for the requests panel because I believe it's going to be useful in other places too (like stacktraces). |
|
That's fair about mentioning the editor setting the templates panel documentation. I think we do want to have this mentioned in the changes.rst file so folks get alerted to the change in the next release. |
|
Done! |
federicobond
force-pushed
the
open-in-editor
branch
from
5d4d274 to
943037d
Compare
There was a problem hiding this comment.
I'm good with these changes. I'd like @matthiask to agree (I don't want to merge a new feature unilaterally). He's out on holiday currently, so it may be a few weeks.
|
Thank you @federicobond for your patience and perseverance! |
Description
This adds a setting to configure an Open in editor URL when you click on a template path. Makes it easier to jump directly to the template and edit. Can develop it further and/or add tests if there is interest in the feature.
Checklist:
docs/changes.rst.